CVE-2024-1631 (GCVE-0-2024-1631)

Vulnerability from cvelistv5 – Published: 2024-02-21 02:12 – Updated: 2024-08-16 14:55
VLAI?
Title
agent-js: Insecure Key Generation in `Ed25519KeyIdentity.generate`
Summary
Impact: The library offers a function to generate an ed25519 key pair via Ed25519KeyIdentity.generate with an optional param to provide a 32 byte seed value, which will then be used as the secret key. When no seed value is provided, it is expected that the library generates the secret key using secure randomness. However, a recent change broke this guarantee and uses an insecure seed for key pair generation. Since the private key of this identity (535yc-uxytb-gfk7h-tny7p-vjkoe-i4krp-3qmcl-uqfgr-cpgej-yqtjq-rqe) is compromised, one could lose funds associated with the principal on ledgers or lose access to a canister where this principal is the controller.
Severity ?
9.1 (Critical)
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:N
CWE
  • CWE-321 - Use of Hard-coded Cryptographic Key
  • CWE-330 - Use of Insufficiently Random Values
Assigner
References
Impacted products
Vendor Product Version
Internet Computer agent-js Affected: v0.20.0-beta.0 , < v1.0.1 (1.0.1)
Create a notification for this product.
Show details on NVD website
To clipboard 

{
  "containers": {
    "adp": [
      {
        "providerMetadata": {
          "dateUpdated": "2024-08-01T18:48:20.675Z",
          "orgId": "af854a3a-2127-422b-91ae-364da2661108",
          "shortName": "CVE"
        },
        "references": [
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://github.com/dfinity/agent-js/pull/851"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://www.npmjs.com/package/@dfinity/identity/v/1.0.1"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://github.com/dfinity/agent-js"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://agent-js.icp.xyz/identity/index.html"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://github.com/dfinity/agent-js/security/advisories/GHSA-c9vv-fhgv-cjc3"
          }
        ],
        "title": "CVE Program Container"
      },
      {
        "affected": [
          {
            "cpes": [
              "cpe:2.3:a:dfinity:agent-js:*:*:*:*:*:*:*:*"
            ],
            "defaultStatus": "unaffected",
            "product": "agent-js",
            "vendor": "dfinity",
            "versions": [
              {
                "lessThan": "v1.0.1",
                "status": "affected",
                "version": "v0.20.0-beta.0",
                "versionType": "custom"
              }
            ]
          }
        ],
        "metrics": [
          {
            "other": {
              "content": {
                "id": "CVE-2024-1631",
                "options": [
                  {
                    "Exploitation": "none"
                  },
                  {
                    "Automatable": "yes"
                  },
                  {
                    "Technical Impact": "total"
                  }
                ],
                "role": "CISA Coordinator",
                "timestamp": "2024-08-14T20:25:01.551447Z",
                "version": "2.0.3"
              },
              "type": "ssvc"
            }
          }
        ],
        "providerMetadata": {
          "dateUpdated": "2024-08-16T14:55:17.037Z",
          "orgId": "134c704f-9b21-4f2e-91b3-4a467353bcc0",
          "shortName": "CISA-ADP"
        },
        "title": "CISA ADP Vulnrichment"
      }
    ],
    "cna": {
      "affected": [
        {
          "defaultStatus": "unaffected",
          "product": "agent-js",
          "programFiles": [
            "https://github.com/dfinity/agent-js/blob/main/packages/identity/src/identity/ed25519.ts"
          ],
          "vendor": "Internet Computer",
          "versions": [
            {
              "lessThan": "v1.0.1",
              "status": "affected",
              "version": "v0.20.0-beta.0",
              "versionType": "1.0.1"
            }
          ]
        }
      ],
      "descriptions": [
        {
          "lang": "en",
          "supportingMedia": [
            {
              "base64": false,
              "type": "text/html",
              "value": "Impact: The library offers a function to generate an ed25519 key pair via Ed25519KeyIdentity.generate with an optional param to provide a 32 byte seed value, which will then be used as the secret key. When no seed value is provided, it is expected that the library generates the secret key using secure randomness. However, a recent change broke this guarantee and uses an insecure seed for key pair generation. Since the private key of this identity (535yc-uxytb-gfk7h-tny7p-vjkoe-i4krp-3qmcl-uqfgr-cpgej-yqtjq-rqe) is compromised, one could lose funds associated with the principal on ledgers or lose access to a canister where this principal is the controller. \u003cbr\u003e"
            }
          ],
          "value": "Impact: The library offers a function to generate an ed25519 key pair via Ed25519KeyIdentity.generate with an optional param to provide a 32 byte seed value, which will then be used as the secret key. When no seed value is provided, it is expected that the library generates the secret key using secure randomness. However, a recent change broke this guarantee and uses an insecure seed for key pair generation. Since the private key of this identity (535yc-uxytb-gfk7h-tny7p-vjkoe-i4krp-3qmcl-uqfgr-cpgej-yqtjq-rqe) is compromised, one could lose funds associated with the principal on ledgers or lose access to a canister where this principal is the controller. \n"
        }
      ],
      "impacts": [
        {
          "descriptions": [
            {
              "lang": "en",
              "value": "Broken access control"
            }
          ]
        }
      ],
      "metrics": [
        {
          "cvssV3_1": {
            "attackComplexity": "LOW",
            "attackVector": "NETWORK",
            "availabilityImpact": "NONE",
            "baseScore": 9.1,
            "baseSeverity": "CRITICAL",
            "confidentialityImpact": "HIGH",
            "integrityImpact": "HIGH",
            "privilegesRequired": "NONE",
            "scope": "UNCHANGED",
            "userInteraction": "NONE",
            "vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:N",
            "version": "3.1"
          },
          "format": "CVSS",
          "scenarios": [
            {
              "lang": "en",
              "value": "GENERAL"
            }
          ]
        }
      ],
      "problemTypes": [
        {
          "descriptions": [
            {
              "cweId": "CWE-321",
              "description": "CWE-321: Use of Hard-coded Cryptographic Key",
              "lang": "en",
              "type": "CWE"
            }
          ]
        },
        {
          "descriptions": [
            {
              "cweId": "CWE-330",
              "description": "CWE-330: Use of Insufficiently Random Values",
              "lang": "en",
              "type": "CWE"
            }
          ]
        }
      ],
      "providerMetadata": {
        "dateUpdated": "2024-02-21T05:09:43.340Z",
        "orgId": "6b35d637-e00f-4228-858c-b20ad6e1d07b",
        "shortName": "Dfinity"
      },
      "references": [
        {
          "url": "https://github.com/dfinity/agent-js/pull/851"
        },
        {
          "url": "https://www.npmjs.com/package/@dfinity/identity/v/1.0.1"
        },
        {
          "url": "https://github.com/dfinity/agent-js"
        },
        {
          "url": "https://agent-js.icp.xyz/identity/index.html"
        },
        {
          "url": "https://github.com/dfinity/agent-js/security/advisories/GHSA-c9vv-fhgv-cjc3"
        }
      ],
      "source": {
        "discovery": "UNKNOWN"
      },
      "title": "agent-js: Insecure Key Generation in `Ed25519KeyIdentity.generate`",
      "x_generator": {
        "engine": "Vulnogram 0.1.0-dev"
      }
    }
  },
  "cveMetadata": {
    "assignerOrgId": "6b35d637-e00f-4228-858c-b20ad6e1d07b",
    "assignerShortName": "Dfinity",
    "cveId": "CVE-2024-1631",
    "datePublished": "2024-02-21T02:12:38.403Z",
    "dateReserved": "2024-02-19T15:58:47.713Z",
    "dateUpdated": "2024-08-16T14:55:17.037Z",
    "state": "PUBLISHED"
  },
  "dataType": "CVE_RECORD",
  "dataVersion": "5.1",
  "vulnerability-lookup:meta": {
    "vulnrichment": {
      "containers": "{\"adp\": [{\"title\": \"CVE Program Container\", \"references\": [{\"url\": \"https://github.com/dfinity/agent-js/pull/851\", \"tags\": [\"x_transferred\"]}, {\"url\": \"https://www.npmjs.com/package/@dfinity/identity/v/1.0.1\", \"tags\": [\"x_transferred\"]}, {\"url\": \"https://github.com/dfinity/agent-js\", \"tags\": [\"x_transferred\"]}, {\"url\": \"https://agent-js.icp.xyz/identity/index.html\", \"tags\": [\"x_transferred\"]}, {\"url\": \"https://github.com/dfinity/agent-js/security/advisories/GHSA-c9vv-fhgv-cjc3\", \"tags\": [\"x_transferred\"]}], \"providerMetadata\": {\"orgId\": \"af854a3a-2127-422b-91ae-364da2661108\", \"shortName\": \"CVE\", \"dateUpdated\": \"2024-08-01T18:48:20.675Z\"}}, {\"title\": \"CISA ADP Vulnrichment\", \"metrics\": [{\"other\": {\"type\": \"ssvc\", \"content\": {\"id\": \"CVE-2024-1631\", \"role\": \"CISA Coordinator\", \"options\": [{\"Exploitation\": \"none\"}, {\"Automatable\": \"yes\"}, {\"Technical Impact\": \"total\"}], \"version\": \"2.0.3\", \"timestamp\": \"2024-08-14T20:25:01.551447Z\"}}}], \"affected\": [{\"cpes\": [\"cpe:2.3:a:dfinity:agent-js:*:*:*:*:*:*:*:*\"], \"vendor\": \"dfinity\", \"product\": \"agent-js\", \"versions\": [{\"status\": \"affected\", \"version\": \"v0.20.0-beta.0\", \"lessThan\": \"v1.0.1\", \"versionType\": \"custom\"}], \"defaultStatus\": \"unaffected\"}], \"providerMetadata\": {\"orgId\": \"134c704f-9b21-4f2e-91b3-4a467353bcc0\", \"shortName\": \"CISA-ADP\", \"dateUpdated\": \"2024-08-14T20:28:08.335Z\"}}], \"cna\": {\"title\": \"agent-js: Insecure Key Generation in `Ed25519KeyIdentity.generate`\", \"source\": {\"discovery\": \"UNKNOWN\"}, \"impacts\": [{\"descriptions\": [{\"lang\": \"en\", \"value\": \"Broken access control\"}]}], \"metrics\": [{\"format\": \"CVSS\", \"cvssV3_1\": {\"scope\": \"UNCHANGED\", \"version\": \"3.1\", \"baseScore\": 9.1, \"attackVector\": \"NETWORK\", \"baseSeverity\": \"CRITICAL\", \"vectorString\": \"CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:N\", \"integrityImpact\": \"HIGH\", \"userInteraction\": \"NONE\", \"attackComplexity\": \"LOW\", \"availabilityImpact\": \"NONE\", \"privilegesRequired\": \"NONE\", \"confidentialityImpact\": \"HIGH\"}, \"scenarios\": [{\"lang\": \"en\", \"value\": \"GENERAL\"}]}], \"affected\": [{\"vendor\": \"Internet Computer\", \"product\": \"agent-js\", \"versions\": [{\"status\": \"affected\", \"version\": \"v0.20.0-beta.0\", \"lessThan\": \"v1.0.1\", \"versionType\": \"1.0.1\"}], \"programFiles\": [\"https://github.com/dfinity/agent-js/blob/main/packages/identity/src/identity/ed25519.ts\"], \"defaultStatus\": \"unaffected\"}], \"references\": [{\"url\": \"https://github.com/dfinity/agent-js/pull/851\"}, {\"url\": \"https://www.npmjs.com/package/@dfinity/identity/v/1.0.1\"}, {\"url\": \"https://github.com/dfinity/agent-js\"}, {\"url\": \"https://agent-js.icp.xyz/identity/index.html\"}, {\"url\": \"https://github.com/dfinity/agent-js/security/advisories/GHSA-c9vv-fhgv-cjc3\"}], \"x_generator\": {\"engine\": \"Vulnogram 0.1.0-dev\"}, \"descriptions\": [{\"lang\": \"en\", \"value\": \"Impact: The library offers a function to generate an ed25519 key pair via Ed25519KeyIdentity.generate with an optional param to provide a 32 byte seed value, which will then be used as the secret key. When no seed value is provided, it is expected that the library generates the secret key using secure randomness. However, a recent change broke this guarantee and uses an insecure seed for key pair generation. Since the private key of this identity (535yc-uxytb-gfk7h-tny7p-vjkoe-i4krp-3qmcl-uqfgr-cpgej-yqtjq-rqe) is compromised, one could lose funds associated with the principal on ledgers or lose access to a canister where this principal is the controller. \\n\", \"supportingMedia\": [{\"type\": \"text/html\", \"value\": \"Impact: The library offers a function to generate an ed25519 key pair via Ed25519KeyIdentity.generate with an optional param to provide a 32 byte seed value, which will then be used as the secret key. When no seed value is provided, it is expected that the library generates the secret key using secure randomness. However, a recent change broke this guarantee and uses an insecure seed for key pair generation. Since the private key of this identity (535yc-uxytb-gfk7h-tny7p-vjkoe-i4krp-3qmcl-uqfgr-cpgej-yqtjq-rqe) is compromised, one could lose funds associated with the principal on ledgers or lose access to a canister where this principal is the controller. \u003cbr\u003e\", \"base64\": false}]}], \"problemTypes\": [{\"descriptions\": [{\"lang\": \"en\", \"type\": \"CWE\", \"cweId\": \"CWE-321\", \"description\": \"CWE-321: Use of Hard-coded Cryptographic Key\"}]}, {\"descriptions\": [{\"lang\": \"en\", \"type\": \"CWE\", \"cweId\": \"CWE-330\", \"description\": \"CWE-330: Use of Insufficiently Random Values\"}]}], \"providerMetadata\": {\"orgId\": \"6b35d637-e00f-4228-858c-b20ad6e1d07b\", \"shortName\": \"Dfinity\", \"dateUpdated\": \"2024-02-21T05:09:43.340Z\"}}}",
      "cveMetadata": "{\"cveId\": \"CVE-2024-1631\", \"state\": \"PUBLISHED\", \"dateUpdated\": \"2024-08-16T14:55:17.037Z\", \"dateReserved\": \"2024-02-19T15:58:47.713Z\", \"assignerOrgId\": \"6b35d637-e00f-4228-858c-b20ad6e1d07b\", \"datePublished\": \"2024-02-21T02:12:38.403Z\", \"assignerShortName\": \"Dfinity\"}",
      "dataType": "CVE_RECORD",
      "dataVersion": "5.1"
    }
  }
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.




Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or observed by the user.
  • Confirmed: The vulnerability has been validated from an analyst's perspective.
  • Published Proof of Concept: A public proof of concept is available for this vulnerability.
  • Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
  • Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
  • Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
  • Not confirmed: The user expressed doubt about the validity of the vulnerability.
  • Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.



Detection rules are retrieved from Rulezet.