CVE-2024-41012 (GCVE-0-2024-41012)

Vulnerability from cvelistv5 – Published: 2024-07-23 08:06 – Updated: 2025-11-03 21:59
VLAI?
Title
filelock: Remove locks reliably when fcntl/close race is detected
Summary
In the Linux kernel, the following vulnerability has been resolved: filelock: Remove locks reliably when fcntl/close race is detected When fcntl_setlk() races with close(), it removes the created lock with do_lock_file_wait(). However, LSMs can allow the first do_lock_file_wait() that created the lock while denying the second do_lock_file_wait() that tries to remove the lock. Separately, posix_lock_file() could also fail to remove a lock due to GFP_KERNEL allocation failure (when splitting a range in the middle). After the bug has been triggered, use-after-free reads will occur in lock_get_status() when userspace reads /proc/locks. This can likely be used to read arbitrary kernel memory, but can't corrupt kernel memory. Fix it by calling locks_remove_posix() instead, which is designed to reliably get rid of POSIX locks associated with the given file and files_struct and is also used by filp_flush().
Severity ?
No CVSS data available.
Assigner
Impacted products
Vendor Product Version
Linux Linux Affected: c293621bbf678a3d85e3ed721c3921c8a670610d , < d30ff33040834c3b9eee29740acd92f9c7ba2250 (git)
Affected: c293621bbf678a3d85e3ed721c3921c8a670610d , < dc2ce1dfceaa0767211a9d963ddb029ab21c4235 (git)
Affected: c293621bbf678a3d85e3ed721c3921c8a670610d , < 5661b9c7ec189406c2dde00837aaa4672efb6240 (git)
Affected: c293621bbf678a3d85e3ed721c3921c8a670610d , < 52c87ab18c76c14d7209646ccb3283b3f5d87b22 (git)
Affected: c293621bbf678a3d85e3ed721c3921c8a670610d , < ef8fc41cd6f95f9a4a3470f085aecf350569a0b3 (git)
Affected: c293621bbf678a3d85e3ed721c3921c8a670610d , < 5f5d0799eb0a01d550c21b7894e26b2d9db55763 (git)
Affected: c293621bbf678a3d85e3ed721c3921c8a670610d , < b6d223942c34057fdfd8f149e763fa823731b224 (git)
Affected: c293621bbf678a3d85e3ed721c3921c8a670610d , < 3cad1bc010416c6dd780643476bc59ed742436b9 (git)
Create a notification for this product.
    Linux Linux Affected: 2.6.13
Unaffected: 0 , < 2.6.13 (semver)
Unaffected: 4.19.319 , ≤ 4.19.* (semver)
Unaffected: 5.4.281 , ≤ 5.4.* (semver)
Unaffected: 5.10.223 , ≤ 5.10.* (semver)
Unaffected: 5.15.164 , ≤ 5.15.* (semver)
Unaffected: 6.1.101 , ≤ 6.1.* (semver)
Unaffected: 6.6.42 , ≤ 6.6.* (semver)
Unaffected: 6.9.9 , ≤ 6.9.* (semver)
Unaffected: 6.10 , ≤ * (original_commit_for_fix)
Create a notification for this product.
Show details on NVD website

{
  "containers": {
    "adp": [
      {
        "providerMetadata": {
          "dateUpdated": "2025-11-03T21:59:16.069Z",
          "orgId": "af854a3a-2127-422b-91ae-364da2661108",
          "shortName": "CVE"
        },
        "references": [
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://git.kernel.org/stable/c/d30ff33040834c3b9eee29740acd92f9c7ba2250"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://git.kernel.org/stable/c/dc2ce1dfceaa0767211a9d963ddb029ab21c4235"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://git.kernel.org/stable/c/5661b9c7ec189406c2dde00837aaa4672efb6240"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://git.kernel.org/stable/c/52c87ab18c76c14d7209646ccb3283b3f5d87b22"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://git.kernel.org/stable/c/ef8fc41cd6f95f9a4a3470f085aecf350569a0b3"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://git.kernel.org/stable/c/5f5d0799eb0a01d550c21b7894e26b2d9db55763"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://git.kernel.org/stable/c/b6d223942c34057fdfd8f149e763fa823731b224"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://git.kernel.org/stable/c/3cad1bc010416c6dd780643476bc59ed742436b9"
          },
          {
            "url": "https://lists.debian.org/debian-lts-announce/2025/01/msg00001.html"
          }
        ],
        "title": "CVE Program Container"
      },
      {
        "metrics": [
          {
            "other": {
              "content": {
                "id": "CVE-2024-41012",
                "options": [
                  {
                    "Exploitation": "none"
                  },
                  {
                    "Automatable": "no"
                  },
                  {
                    "Technical Impact": "partial"
                  }
                ],
                "role": "CISA Coordinator",
                "timestamp": "2024-09-10T16:25:02.584247Z",
                "version": "2.0.3"
              },
              "type": "ssvc"
            }
          }
        ],
        "providerMetadata": {
          "dateUpdated": "2024-09-11T17:34:06.422Z",
          "orgId": "134c704f-9b21-4f2e-91b3-4a467353bcc0",
          "shortName": "CISA-ADP"
        },
        "title": "CISA ADP Vulnrichment"
      }
    ],
    "cna": {
      "affected": [
        {
          "defaultStatus": "unaffected",
          "product": "Linux",
          "programFiles": [
            "fs/locks.c"
          ],
          "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
          "vendor": "Linux",
          "versions": [
            {
              "lessThan": "d30ff33040834c3b9eee29740acd92f9c7ba2250",
              "status": "affected",
              "version": "c293621bbf678a3d85e3ed721c3921c8a670610d",
              "versionType": "git"
            },
            {
              "lessThan": "dc2ce1dfceaa0767211a9d963ddb029ab21c4235",
              "status": "affected",
              "version": "c293621bbf678a3d85e3ed721c3921c8a670610d",
              "versionType": "git"
            },
            {
              "lessThan": "5661b9c7ec189406c2dde00837aaa4672efb6240",
              "status": "affected",
              "version": "c293621bbf678a3d85e3ed721c3921c8a670610d",
              "versionType": "git"
            },
            {
              "lessThan": "52c87ab18c76c14d7209646ccb3283b3f5d87b22",
              "status": "affected",
              "version": "c293621bbf678a3d85e3ed721c3921c8a670610d",
              "versionType": "git"
            },
            {
              "lessThan": "ef8fc41cd6f95f9a4a3470f085aecf350569a0b3",
              "status": "affected",
              "version": "c293621bbf678a3d85e3ed721c3921c8a670610d",
              "versionType": "git"
            },
            {
              "lessThan": "5f5d0799eb0a01d550c21b7894e26b2d9db55763",
              "status": "affected",
              "version": "c293621bbf678a3d85e3ed721c3921c8a670610d",
              "versionType": "git"
            },
            {
              "lessThan": "b6d223942c34057fdfd8f149e763fa823731b224",
              "status": "affected",
              "version": "c293621bbf678a3d85e3ed721c3921c8a670610d",
              "versionType": "git"
            },
            {
              "lessThan": "3cad1bc010416c6dd780643476bc59ed742436b9",
              "status": "affected",
              "version": "c293621bbf678a3d85e3ed721c3921c8a670610d",
              "versionType": "git"
            }
          ]
        },
        {
          "defaultStatus": "affected",
          "product": "Linux",
          "programFiles": [
            "fs/locks.c"
          ],
          "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
          "vendor": "Linux",
          "versions": [
            {
              "status": "affected",
              "version": "2.6.13"
            },
            {
              "lessThan": "2.6.13",
              "status": "unaffected",
              "version": "0",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "4.19.*",
              "status": "unaffected",
              "version": "4.19.319",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "5.4.*",
              "status": "unaffected",
              "version": "5.4.281",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "5.10.*",
              "status": "unaffected",
              "version": "5.10.223",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "5.15.*",
              "status": "unaffected",
              "version": "5.15.164",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "6.1.*",
              "status": "unaffected",
              "version": "6.1.101",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "6.6.*",
              "status": "unaffected",
              "version": "6.6.42",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "6.9.*",
              "status": "unaffected",
              "version": "6.9.9",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "*",
              "status": "unaffected",
              "version": "6.10",
              "versionType": "original_commit_for_fix"
            }
          ]
        }
      ],
      "cpeApplicability": [
        {
          "nodes": [
            {
              "cpeMatch": [
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "4.19.319",
                  "versionStartIncluding": "2.6.13",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "5.4.281",
                  "versionStartIncluding": "2.6.13",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "5.10.223",
                  "versionStartIncluding": "2.6.13",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "5.15.164",
                  "versionStartIncluding": "2.6.13",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "6.1.101",
                  "versionStartIncluding": "2.6.13",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "6.6.42",
                  "versionStartIncluding": "2.6.13",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "6.9.9",
                  "versionStartIncluding": "2.6.13",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "6.10",
                  "versionStartIncluding": "2.6.13",
                  "vulnerable": true
                }
              ],
              "negate": false,
              "operator": "OR"
            }
          ]
        }
      ],
      "descriptions": [
        {
          "lang": "en",
          "value": "In the Linux kernel, the following vulnerability has been resolved:\n\nfilelock: Remove locks reliably when fcntl/close race is detected\n\nWhen fcntl_setlk() races with close(), it removes the created lock with\ndo_lock_file_wait().\nHowever, LSMs can allow the first do_lock_file_wait() that created the lock\nwhile denying the second do_lock_file_wait() that tries to remove the lock.\nSeparately, posix_lock_file() could also fail to\nremove a lock due to GFP_KERNEL allocation failure (when splitting a range\nin the middle).\n\nAfter the bug has been triggered, use-after-free reads will occur in\nlock_get_status() when userspace reads /proc/locks. This can likely be used\nto read arbitrary kernel memory, but can\u0027t corrupt kernel memory.\n\nFix it by calling locks_remove_posix() instead, which is designed to\nreliably get rid of POSIX locks associated with the given file and\nfiles_struct and is also used by filp_flush()."
        }
      ],
      "providerMetadata": {
        "dateUpdated": "2025-05-04T09:20:04.810Z",
        "orgId": "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
        "shortName": "Linux"
      },
      "references": [
        {
          "url": "https://git.kernel.org/stable/c/d30ff33040834c3b9eee29740acd92f9c7ba2250"
        },
        {
          "url": "https://git.kernel.org/stable/c/dc2ce1dfceaa0767211a9d963ddb029ab21c4235"
        },
        {
          "url": "https://git.kernel.org/stable/c/5661b9c7ec189406c2dde00837aaa4672efb6240"
        },
        {
          "url": "https://git.kernel.org/stable/c/52c87ab18c76c14d7209646ccb3283b3f5d87b22"
        },
        {
          "url": "https://git.kernel.org/stable/c/ef8fc41cd6f95f9a4a3470f085aecf350569a0b3"
        },
        {
          "url": "https://git.kernel.org/stable/c/5f5d0799eb0a01d550c21b7894e26b2d9db55763"
        },
        {
          "url": "https://git.kernel.org/stable/c/b6d223942c34057fdfd8f149e763fa823731b224"
        },
        {
          "url": "https://git.kernel.org/stable/c/3cad1bc010416c6dd780643476bc59ed742436b9"
        }
      ],
      "title": "filelock: Remove locks reliably when fcntl/close race is detected",
      "x_generator": {
        "engine": "bippy-1.2.0"
      }
    }
  },
  "cveMetadata": {
    "assignerOrgId": "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
    "assignerShortName": "Linux",
    "cveId": "CVE-2024-41012",
    "datePublished": "2024-07-23T08:06:02.579Z",
    "dateReserved": "2024-07-12T12:17:45.611Z",
    "dateUpdated": "2025-11-03T21:59:16.069Z",
    "state": "PUBLISHED"
  },
  "dataType": "CVE_RECORD",
  "dataVersion": "5.2",
  "vulnerability-lookup:meta": {
    "vulnrichment": {
      "containers": "{\"adp\": [{\"title\": \"CVE Program Container\", \"references\": [{\"url\": \"https://git.kernel.org/stable/c/d30ff33040834c3b9eee29740acd92f9c7ba2250\", \"tags\": [\"x_transferred\"]}, {\"url\": \"https://git.kernel.org/stable/c/dc2ce1dfceaa0767211a9d963ddb029ab21c4235\", \"tags\": [\"x_transferred\"]}, {\"url\": \"https://git.kernel.org/stable/c/5661b9c7ec189406c2dde00837aaa4672efb6240\", \"tags\": [\"x_transferred\"]}, {\"url\": \"https://git.kernel.org/stable/c/52c87ab18c76c14d7209646ccb3283b3f5d87b22\", \"tags\": [\"x_transferred\"]}, {\"url\": \"https://git.kernel.org/stable/c/ef8fc41cd6f95f9a4a3470f085aecf350569a0b3\", \"tags\": [\"x_transferred\"]}, {\"url\": \"https://git.kernel.org/stable/c/5f5d0799eb0a01d550c21b7894e26b2d9db55763\", \"tags\": [\"x_transferred\"]}, {\"url\": \"https://git.kernel.org/stable/c/b6d223942c34057fdfd8f149e763fa823731b224\", \"tags\": [\"x_transferred\"]}, {\"url\": \"https://git.kernel.org/stable/c/3cad1bc010416c6dd780643476bc59ed742436b9\", \"tags\": [\"x_transferred\"]}], \"providerMetadata\": {\"orgId\": \"af854a3a-2127-422b-91ae-364da2661108\", \"shortName\": \"CVE\", \"dateUpdated\": \"2024-08-02T04:39:55.923Z\"}}, {\"title\": \"CISA ADP Vulnrichment\", \"metrics\": [{\"other\": {\"type\": \"ssvc\", \"content\": {\"id\": \"CVE-2024-41012\", \"role\": \"CISA Coordinator\", \"options\": [{\"Exploitation\": \"none\"}, {\"Automatable\": \"no\"}, {\"Technical Impact\": \"partial\"}], \"version\": \"2.0.3\", \"timestamp\": \"2024-09-10T16:25:02.584247Z\"}}}], \"providerMetadata\": {\"orgId\": \"134c704f-9b21-4f2e-91b3-4a467353bcc0\", \"shortName\": \"CISA-ADP\", \"dateUpdated\": \"2024-09-11T12:42:20.688Z\"}}], \"cna\": {\"title\": \"filelock: Remove locks reliably when fcntl/close race is detected\", \"affected\": [{\"repo\": \"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git\", \"vendor\": \"Linux\", \"product\": \"Linux\", \"versions\": [{\"status\": \"affected\", \"version\": \"c293621bbf678a3d85e3ed721c3921c8a670610d\", \"lessThan\": \"d30ff33040834c3b9eee29740acd92f9c7ba2250\", \"versionType\": \"git\"}, {\"status\": \"affected\", \"version\": \"c293621bbf678a3d85e3ed721c3921c8a670610d\", \"lessThan\": \"dc2ce1dfceaa0767211a9d963ddb029ab21c4235\", \"versionType\": \"git\"}, {\"status\": \"affected\", \"version\": \"c293621bbf678a3d85e3ed721c3921c8a670610d\", \"lessThan\": \"5661b9c7ec189406c2dde00837aaa4672efb6240\", \"versionType\": \"git\"}, {\"status\": \"affected\", \"version\": \"c293621bbf678a3d85e3ed721c3921c8a670610d\", \"lessThan\": \"52c87ab18c76c14d7209646ccb3283b3f5d87b22\", \"versionType\": \"git\"}, {\"status\": \"affected\", \"version\": \"c293621bbf678a3d85e3ed721c3921c8a670610d\", \"lessThan\": \"ef8fc41cd6f95f9a4a3470f085aecf350569a0b3\", \"versionType\": \"git\"}, {\"status\": \"affected\", \"version\": \"c293621bbf678a3d85e3ed721c3921c8a670610d\", \"lessThan\": \"5f5d0799eb0a01d550c21b7894e26b2d9db55763\", \"versionType\": \"git\"}, {\"status\": \"affected\", \"version\": \"c293621bbf678a3d85e3ed721c3921c8a670610d\", \"lessThan\": \"b6d223942c34057fdfd8f149e763fa823731b224\", \"versionType\": \"git\"}, {\"status\": \"affected\", \"version\": \"c293621bbf678a3d85e3ed721c3921c8a670610d\", \"lessThan\": \"3cad1bc010416c6dd780643476bc59ed742436b9\", \"versionType\": \"git\"}], \"programFiles\": [\"fs/locks.c\"], \"defaultStatus\": \"unaffected\"}, {\"repo\": \"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git\", \"vendor\": \"Linux\", \"product\": \"Linux\", \"versions\": [{\"status\": \"affected\", \"version\": \"2.6.13\"}, {\"status\": \"unaffected\", \"version\": \"0\", \"lessThan\": \"2.6.13\", \"versionType\": \"semver\"}, {\"status\": \"unaffected\", \"version\": \"4.19.319\", \"versionType\": \"semver\", \"lessThanOrEqual\": \"4.19.*\"}, {\"status\": \"unaffected\", \"version\": \"5.4.281\", \"versionType\": \"semver\", \"lessThanOrEqual\": \"5.4.*\"}, {\"status\": \"unaffected\", \"version\": \"5.10.223\", \"versionType\": \"semver\", \"lessThanOrEqual\": \"5.10.*\"}, {\"status\": \"unaffected\", \"version\": \"5.15.164\", \"versionType\": \"semver\", \"lessThanOrEqual\": \"5.15.*\"}, {\"status\": \"unaffected\", \"version\": \"6.1.101\", \"versionType\": \"semver\", \"lessThanOrEqual\": \"6.1.*\"}, {\"status\": \"unaffected\", \"version\": \"6.6.42\", \"versionType\": \"semver\", \"lessThanOrEqual\": \"6.6.*\"}, {\"status\": \"unaffected\", \"version\": \"6.9.9\", \"versionType\": \"semver\", \"lessThanOrEqual\": \"6.9.*\"}, {\"status\": \"unaffected\", \"version\": \"6.10\", \"versionType\": \"original_commit_for_fix\", \"lessThanOrEqual\": \"*\"}], \"programFiles\": [\"fs/locks.c\"], \"defaultStatus\": \"affected\"}], \"references\": [{\"url\": \"https://git.kernel.org/stable/c/d30ff33040834c3b9eee29740acd92f9c7ba2250\"}, {\"url\": \"https://git.kernel.org/stable/c/dc2ce1dfceaa0767211a9d963ddb029ab21c4235\"}, {\"url\": \"https://git.kernel.org/stable/c/5661b9c7ec189406c2dde00837aaa4672efb6240\"}, {\"url\": \"https://git.kernel.org/stable/c/52c87ab18c76c14d7209646ccb3283b3f5d87b22\"}, {\"url\": \"https://git.kernel.org/stable/c/ef8fc41cd6f95f9a4a3470f085aecf350569a0b3\"}, {\"url\": \"https://git.kernel.org/stable/c/5f5d0799eb0a01d550c21b7894e26b2d9db55763\"}, {\"url\": \"https://git.kernel.org/stable/c/b6d223942c34057fdfd8f149e763fa823731b224\"}, {\"url\": \"https://git.kernel.org/stable/c/3cad1bc010416c6dd780643476bc59ed742436b9\"}], \"x_generator\": {\"engine\": \"bippy-5f407fcff5a0\"}, \"descriptions\": [{\"lang\": \"en\", \"value\": \"In the Linux kernel, the following vulnerability has been resolved:\\n\\nfilelock: Remove locks reliably when fcntl/close race is detected\\n\\nWhen fcntl_setlk() races with close(), it removes the created lock with\\ndo_lock_file_wait().\\nHowever, LSMs can allow the first do_lock_file_wait() that created the lock\\nwhile denying the second do_lock_file_wait() that tries to remove the lock.\\nSeparately, posix_lock_file() could also fail to\\nremove a lock due to GFP_KERNEL allocation failure (when splitting a range\\nin the middle).\\n\\nAfter the bug has been triggered, use-after-free reads will occur in\\nlock_get_status() when userspace reads /proc/locks. This can likely be used\\nto read arbitrary kernel memory, but can\u0027t corrupt kernel memory.\\n\\nFix it by calling locks_remove_posix() instead, which is designed to\\nreliably get rid of POSIX locks associated with the given file and\\nfiles_struct and is also used by filp_flush().\"}], \"providerMetadata\": {\"orgId\": \"416baaa9-dc9f-4396-8d5f-8c081fb06d67\", \"shortName\": \"Linux\", \"dateUpdated\": \"2024-12-19T09:10:02.636Z\"}}}",
      "cveMetadata": "{\"cveId\": \"CVE-2024-41012\", \"state\": \"PUBLISHED\", \"dateUpdated\": \"2024-12-19T09:10:02.636Z\", \"dateReserved\": \"2024-07-12T12:17:45.611Z\", \"assignerOrgId\": \"416baaa9-dc9f-4396-8d5f-8c081fb06d67\", \"datePublished\": \"2024-07-23T08:06:02.579Z\", \"assignerShortName\": \"Linux\"}",
      "dataType": "CVE_RECORD",
      "dataVersion": "5.1"
    }
  }
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.


Loading…

Loading…

Loading…

Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or observed by the user.
  • Confirmed: The vulnerability has been validated from an analyst's perspective.
  • Published Proof of Concept: A public proof of concept is available for this vulnerability.
  • Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
  • Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
  • Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
  • Not confirmed: The user expressed doubt about the validity of the vulnerability.
  • Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.


Loading…

Detection rules are retrieved from Rulezet.

Loading…

Loading…